linux-kernel - Re: [PATCH] locks: rename file-private locks to "open file description locks"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53568529.2030103@panasas.com>
Date:	Tue, 22 Apr 2014 18:05:13 +0300
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Jeff Layton <jlayton@...hat.com>
CC:	<linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<samba-technical@...ts.samba.org>,
	Ganesha NFS List <nfs-ganesha-devel@...ts.sourceforge.net>,
	libc-alpha <libc-alpha@...rceware.org>,
	Michael Kerrisk <mtk.manpages@...il.com>,
	Christoph Hellwig <hch@...radead.org>,
	"Carlos O'Donell" <carlos@...hat.com>,
	Stefan Metzmacher <metze@...ba.org>,
	Andy Lutomirski <luto@...capital.net>,
	Frank Filz <ffilzlnx@...dspring.com>,
	"Theodore Ts'o" <tytso@....edu>
Subject: Re: [PATCH] locks: rename file-private locks to "open file description
 locks"

On 04/22/2014 05:55 PM, Jeff Layton wrote:
> On Tue, 22 Apr 2014 17:45:31 +0300
> Boaz Harrosh <openosd@...il.com> wrote:
> 
> 
> There's a big difference between the descriptor and the description.
> 
> The numerical value you get back from something like open() is a file
> descriptor. 

Ha OK sorry I thought that was a file-handle I think in FBSD they
call it that. I guess file-handle is the NFS thing.

I guess the most common name for those is file-No, fn in
code

> The thing that that value points to internally in the
> kernel is the file description. 

I did not know that and I completely interchanged these two.
In Kernel this is called plain "struct file" so I've never
seen this name used before.

OK Now it is clear

> It's very important that we do not
> conflate the two here as these locks are associated with the file
> description and not the file descriptor.
> 

Sure you are right.

> The best way to illustrate this is the interaction with dup() -- see
> the LWN article on these for a complete overview.
> 

I know the difference very well only I got the names mixed

Thanks
Boaz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/