linux-kernel - Re: [PATCH v2 05/13] extcon: extcon-class: improve extcon client API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140422150336.GA612@drone.musicnaut.iki.fi>
Date:	Tue, 22 Apr 2014 18:03:36 +0300
From:	Aaro Koskinen <aaro.koskinen@....fi>
To:	Robert Baldyga <r.baldyga@...sung.com>
Cc:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	rob@...dley.net, myungjoo.ham@...sung.com, cw00.choi@...sung.com,
	dbaryshkov@...il.com, dwmw2@...radead.org, balbi@...com,
	gregkh@...uxfoundation.org, grant.likely@...aro.org,
	ldewangan@...dia.com, kishon@...com, gg@...mlogic.co.uk,
	anton@...msg.org, jonghwa3.lee@...sung.com, rongjun.ying@....com,
	linux@...ck-us.net, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	patches@...nsource.wolfsonmicro.com, linux-usb@...r.kernel.org,
	linux-omap@...r.kernel.org, m.szyprowski@...sung.com,
	t.figa@...sung.com
Subject: Re: [PATCH v2 05/13] extcon: extcon-class: improve extcon client API

Hi,

On Tue, Apr 22, 2014 at 08:21:35AM +0200, Robert Baldyga wrote:
> On 04/19/2014 12:52 PM, Aaro Koskinen wrote:
> > On Mon, Apr 14, 2014 at 01:46:16PM +0200, Robert Baldyga wrote:
> >>  	dev_info(&pdev->dev,
> >> -		 "OMAP USB OTG controller rev %d.%d (%s, id=%d, vbus=%d)\n",
> >> -		 (rev >> 4) & 0xf, rev & 0xf, config->extcon, otg_dev->id,
> >> +		 "OMAP USB OTG controller rev %d.%d (id=%d, vbus=%d)\n",
> >> +		 (rev >> 4) & 0xf, rev & 0xf, otg_dev->id,
> >>  		 otg_dev->vbus);
> > 
> > This change is unrelated to the patch and not needed.
> >
> 
> It's related because we no longer use config->extcon since we have
> cable-oriented API. We can keep displaying it, but this value is
> actually meaningless.

It's not completely meaningless, as the cable is searched using that name.

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/