linux-kernel - Re: [PATCH v6 01/19] usb: phy: msm: Make driver selectable on ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140422152425.GL5524@saruman.home>
Date:	Tue, 22 Apr 2014 10:24:25 -0500
From:	Felipe Balbi <balbi@...com>
To:	"Ivan T. Ivanov" <iivanov@...sol.com>
CC:	<balbi@...com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH v6 01/19] usb: phy: msm: Make driver selectable on
 ARCH_QCOM

On Tue, Apr 22, 2014 at 06:16:35PM +0300, Ivan T. Ivanov wrote:
> 
> Hi, 
> 
> On Tue, 2014-04-22 at 09:57 -0500, Felipe Balbi wrote:
> > On Tue, Apr 22, 2014 at 12:20:20PM +0300, Ivan T. Ivanov wrote:
> > > From: "Ivan T. Ivanov" <iivanov@...sol.com>
> > > 
> > > Controller could be found on APQ and MSM platforms,
> > > make configuration description more generic.
> > > 
> > > Signed-off-by: Ivan T. Ivanov <iivanov@...sol.com>
> > > ---
> > >  drivers/usb/phy/Kconfig | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> > > index 416e0c8..0c668a3 100644
> > > --- a/drivers/usb/phy/Kconfig
> > > +++ b/drivers/usb/phy/Kconfig
> > > @@ -171,11 +171,11 @@ config USB_ISP1301
> > >  	  module will be called phy-isp1301.
> > > 
> > >  config USB_MSM_OTG
> > > -	tristate "OTG support for Qualcomm on-chip USB controller"
> > > -	depends on (USB || USB_GADGET) && ARCH_MSM
> > > +	tristate "Qualcomm on-chip USB OTG controller support"
> > > +	depends on (USB || USB_GADGET) && (ARCH_MSM || ARCH_QCOM)
> > 
> > I would actually drop USB || USB_GADGET dependency here just make it
> > easier to enable the driver on Kconfig, other you have to enable
> > USB_SUPPORT, then enable USB, go back one menu level, go down to PHY
> > menu, and choose this driver.
> > 
> 
> Because phy directory already depends on USB_SUPPORT?

right

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)