linux-kernel - Re: [PATCH 06/28] nios2: Memory management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53569A7A.70405@codesourcery.com>
Date:	Wed, 23 Apr 2014 00:36:10 +0800
From:	Chung-Lin Tang <cltang@...esourcery.com>
To:	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
CC:	Tobias Klauser <tklauser@...tanz.ch>,
	Ley Foon Tan <lftan@...era.com>,
	<linux-arch@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <lftan.linux@...il.com>
Subject: Re: [PATCH 06/28] nios2: Memory management

On 2014/4/23 上午 12:27, Ezequiel Garcia wrote:
> On Apr 23, Chung-Lin Tang wrote:
>> On 2014/4/22 下午 11:35, Ezequiel Garcia wrote:
>>> On Apr 22, Tobias Klauser wrote:
>>>> On 2014-04-22 at 16:24:43 +0200, Ezequiel Garcia <ezequiel.garcia@...e-electrons.com> wrote:
>>>>> Hi Ley Foon,
>>>>>
>>>>> On Apr 18, Ley Foon Tan wrote:
>>>>>> +/*
>>>>>> + * PAGE_SHIFT determines the page size
>>>>>> + */
>>>>>> +#define PAGE_SHIFT	12
>>>>>> +#define PAGE_SIZE	4096
>>>>>> +#define PAGE_MASK	(~(PAGE_SIZE - 1))
>>>>>> +
>>>>>
>>>>> How about something like this:
>>>>>
>>>>> /* PAGE_SHIFT determines the page size */
>>>>> #define PAGE_SHIFT              12
>>>>> #define PAGE_SIZE               (_AC(1,UL) << PAGE_SHIFT)
>>>>> #define PAGE_MASK               (~((1 << PAGE_SHIFT) - 1))
>>>>>
>>>>> Otherwise, the PAGE_SIZE macro above produces some warnings, IIRC.
>>>>
>>>> AFAIR old nios2 GCC versions (the 4.1 version from Windriver, IIRC)
>>>> would complain about something like the above, that's the reason I added
>>>> an explicit value for PAGE_SIZE back then.
>>>>
>>>
>>> Other than being "pretty" the above fix is to remove a mismatch type
>>> warning. You can get rid of the warning in different ways:
>>>
>>> ifdef __ASSEMBLY__
>>> define PAGE_SIZE       4096
>>> else
>>> define PAGE_SIZE       4096UL
>>> endif
>>>
>>>> I assume with the new nios2 GCC this should no longer be necessary and
>>>> Ezequiel's fix should be fine.
>>>
>>> Speaking of GCC... is there a libc available to test this kernel port?
>>> (which I assume uses the generic syscall ABI)
>>
>> It's submitted to libc-alpha, also still review in progress.
>>
> 
> Do you plan to support uclibc?

No, we (Mentor Graphics) are only doing glibc work at this point.

Chung-Lin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/