linux-kernel - Re: [PATCH] sh-pfc: r8a7790: Fix definition of IPSR5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2172750.fMdy2nvht6@avalon>
Date:	Tue, 22 Apr 2014 18:39:06 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Phil Edworthy <phil.edworthy@...esas.com>,
	Simon Horman <horms+renesas@...ge.net.au>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Guido Piasenza <gpiasenza@...t-in.com>,
	Linux-SH <linux-sh@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sh-pfc: r8a7790: Fix definition of IPSR5

Hi Phil,

Thank you for the patch.

On Tuesday 22 April 2014 16:28:03 Phil Edworthy wrote:
> From: Guido Piasenza <gpiasenza@...t-in.com>
> 
> The extra entry in the table makes SCIFA0_B, and all peripherals after it,
> fail.
> 
> Signed-off-by: Phil Edworthy <phil.edworthy@...esas.com>

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/pinctrl/sh-pfc/pfc-r8a7790.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a7790.c index 4809371..dbf2ef9 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
> @@ -4795,7 +4795,7 @@ static const struct pinmux_cfg_reg
> pinmux_config_regs[] = { /* IP5_23_21 [3] */
>  		FN_WE1_N, FN_IERX, FN_CAN1_RX, FN_VI1_G4,
>  		FN_VI1_G4_B, FN_VI2_R6, FN_SCIFA0_CTS_N_B,
> -		FN_IERX_C, 0,
> +		FN_IERX_C,

I would have put that last entry at the end of the previous line, to have four 
entries on both lines.

>  		/* IP5_20_18 [3] */
>  		FN_WE0_N, FN_IECLK, FN_CAN_CLK,
>  		FN_VI2_VSYNC_N, FN_SCIFA0_TXD_B, FN_VI2_VSYNC_N_B, 0, 0,

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/