[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140422165355.GK1104@krava.brq.redhat.com>
Date: Tue, 22 Apr 2014 18:53:55 +0200
From: Jiri Olsa <jolsa@...hat.com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Ingo Molnar <mingo@...nel.org>,
Paul Mackerras <paulus@...ba.org>,
Namhyung Kim <namhyung.kim@....com>,
LKML <linux-kernel@...r.kernel.org>,
David Ahern <dsahern@...il.com>,
Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 4/9] perf tools: Introduce hists__inc_dump_events()
On Tue, Apr 22, 2014 at 05:49:46PM +0900, Namhyung Kim wrote:
SNIP
> index f955ae5a41c5..883340d7d43e 100644
> --- a/tools/perf/util/hist.c
> +++ b/tools/perf/util/hist.c
> @@ -333,6 +333,19 @@ void hists__inc_nr_events(struct hists *hists, u32 type)
> __events_stats__add(&hists->stats, type, 1);
> }
>
> +void hists__inc_dump_events(struct hists *hists)
> +{
> + if (!dump_trace)
> + return;
> +
> + /*
> + * If dump_trace is enabled, perf will exit before accounting
> + * sample events during hists__output_resort(). Thus it needs to
> + * be done separately.
> + */
> + __events_stats__add(&hists->stats, PERF_RECORD_SAMPLE, 1);
> +}
hum, we already clear all the stats before resorting for output so why done
we call hists__inc_nr_entries from add_hist_entry? (at out label)
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists