linux-kernel - Re: [PATCH] Export irq tracepoints for use by kernel modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140422173854.GA26894@dreric01-Precision-T1600>
Date:	Tue, 22 Apr 2014 10:38:54 -0700
From:	Drew Richardson <drew.richardson@....com>
To:	Josh Boyer <jwboyer@...oraproject.org>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Joe Perches <joe@...ches.com>,
	Ben Greear <greearb@...delatech.com>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	"mathieu.desnoyers@...icios.com" <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH] Export irq tracepoints for use by kernel modules

On Tue, Apr 22, 2014 at 04:01:03PM +0100, Josh Boyer wrote:
> On Tue, Apr 22, 2014 at 10:26 AM, Christoph Hellwig <hch@...radead.org> wrote:
> > On Tue, Apr 22, 2014 at 07:24:20AM -0700, Drew Richardson wrote:
> >> After commit de7b2973903c6cc50b31ee5682a69b2219b9919d ("tracepoint:
> >> Use struct pointer instead of name hash for reg/unreg tracepoints"),
> >> any tracepoints used in a kernel module must be exported.
> >
> > How does this matter given that there aren't any modular users?
> 
> We had a bug report about this breaking systemtap type usage[1].  In
> there, Matthieu suggested that the new for_each_kernel_tracepoint
> interface be used.
> 
> Drew, it would have been proper to CC the author of the change you're
> referencing on all of your patches to export these symbols.
> 
> josh
> 
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1087623
> 

Thanks Josh for pointing out that I should CC Mathieu and
register_tracepoint_module_notifier, which will work for me.

Drew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/