linux-kernel - Re: [PATCH 3.13 08/32] PCI: Enable INTx in pci_reenable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Apr 2014 09:32:23 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
Subject: Re: [PATCH 3.13 08/32] PCI: Enable INTx in pci_reenable_device()
 only when MSI/MSI-X not enabled

On Mon, Apr 21, 2014 at 03:24:29PM +0100, Ben Hutchings wrote:
> On Sun, 2014-04-20 at 19:13 -0700, Greg Kroah-Hartman wrote:
> > 3.13-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Bjorn Helgaas <bhelgaas@...gle.com>
> > 
> > commit 866d54177b4e671cd52bed1fb487d140d7b691f5 upstream.
> > 
> > Andreas reported that after 1f42db786b14 ("PCI: Enable INTx if BIOS left
> > them disabled"), pciehp surprise removal stopped working.
> > 
> > This happens because pci_reenable_device() on the hotplug bridge (used in
> > the pciehp_configure_device() path) clears the Interrupt Disable bit, which
> > apparently breaks the bridge's MSI hotplug event reporting.
> > 
> > Previously we cleared the Interrupt Disable bit in do_pci_enable_device(),
> > which is used by both pci_enable_device() and pci_reenable_device().  But
> > we use pci_reenable_device() after the driver may have enabled MSI or
> > MSI-X, and we *set* Interrupt Disable as part of enabling MSI/MSI-X.
> > 
> > This patch clears Interrupt Disable only when MSI/MSI-X has not been
> > enabled.
> > 
> > Fixes: 1f42db786b14 PCI: Enable INTx if BIOS left them disabled
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=71691
> > Reported-and-tested-by: Andreas Noever <andreas.noever@...il.com>
> > Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> > CC: Sarah Sharp <sarah.a.sharp@...ux.intel.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > 
> > ---
> >  drivers/pci/pci.c |    3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > --- a/drivers/pci/pci.c
> > +++ b/drivers/pci/pci.c
> > @@ -1134,6 +1134,9 @@ static int do_pci_enable_device(struct p
> >  	if (dev->msi_enabled || dev->msix_enabled)
> >  		return 0;
> >  
> > +	if (dev->msi_enabled || dev->msix_enabled)
> > +		return 0;
> > +
> 
> This fix seems to have been applied to two upstream branches and you
> have already applied one instance.

Good catch, I've now removed it, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/