linux-kernel - Re: [PATCH 4/4] cgroup: convert from per-cgroup id to per-subsys id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140422203632.GF2314@mtj.dyndns.org>
Date:	Tue, 22 Apr 2014 16:36:32 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Jianyu Zhan <nasa4836@...il.com>
Cc:	lizefan@...wei.com, containers@...ts.linux-foundation.org,
	cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] cgroup: convert from per-cgroup id to per-subsys id

On Tue, Apr 22, 2014 at 04:03:31PM +0800, Jianyu Zhan wrote:
> Hi, all.
> 
> Sorry, previous patch has a minor fault, and cause a unitialized variable warning.
> I've fixed it up in this.
> 
> Renewed patch:
> ---
> 
> Currently, cgrp->id is only used to look up css's.  As cgroup and
> css's lifetimes is now decoupled, it should be made per-subsystem
> and moved to css->css_id so that lookups are successful until the
> target css is released.

So, css ID can't replace cgroup ID as whole.  It's just that there are
cases where we're currently using cgroup IDs where we should be using
css IDs.  Also, we need to update css creation error path RCU safe so
that idr lookup is always RCU safe.  I already had patches queued for
posting.  Will post them soon.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/