lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Apr 2014 14:44:58 +0930 From: Rusty Russell <rusty@...tcorp.com.au> To: Sergei Ianovich <ynvich@...il.com> Cc: "Elliott\, Robert \(Server Storage\)" <Elliott@...com>, "ynvich\@gmail.com" <ynvich@...il.com>, "Lucas De Marchi" <lucas.de.marchi@...il.com> Subject: Re: [PATCH v2] fix printk output Sergei Ianovich <ynvich@...il.com> writes: > On Tue, 2013-12-10 at 15:59 +1030, Rusty Russell wrote: >> BTW, did you actually hit this? > > # modprobe usb_storage > [ 600.807274] usbcore: registered new interface driver usb-storage > # modprobe -r usb_storage > [ 604.216318] waiting module removal not supported: please upgrade[ > 604.222164] usbcore: deregistering interface driver usb-storage > # modprobe -V > kmod version 9 > > I am using the latest kmod package from emdebian unstable-grip. Sorry, was off on leave. Hmm, Lucas intimated that kmod version 11 started passing this flag correctly. In fact, kmod's modprobe *never* used the O_NONBLOCK (ie. KMOD_REMOVE_NOWAIT) flag, until it was finally enforced in commit 7ab8804448377fb6b8854f2dd288608db01bb43b Author: Lucas De Marchi <lucas.demarchi@...el.com> Date: Fri Sep 20 01:30:07 2013 -0500 See: tools/modprobe.c at that commit: static int rmmod_do_remove_module(struct kmod_module *mod) { const char *modname = kmod_module_get_name(mod); struct kmod_list *deps, *itr; int flags = 0, err; ... if (force) flags |= KMOD_REMOVE_FORCE; err = kmod_module_remove_module(mod, flags); Perhaps we need to just get rid of the kernel message, since we're getting far too many false reports :( Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists