lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Apr 2014 10:24:09 +0200 From: Antoine Ténart <antoine.tenart@...e-electrons.com> To: Rob Herring <robherring2@...il.com> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, Tejun Heo <tj@...nel.org>, zmxu@...vell.com, Jisheng Zhang <jszhang@...vell.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-ide@...r.kernel.org, Alexandre Belloni <alexandre.belloni@...e-electrons.com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH 1/6] ata: ahci: add AHCI support for Berlin SoCs Rob, On Tue, Apr 22, 2014 at 01:54:33PM -0500, Rob Herring wrote: > On Tue, Apr 22, 2014 at 1:47 PM, Rob Herring <robherring2@...il.com> wrote: > > On Tue, Apr 22, 2014 at 10:38 AM, Antoine Ténart > > <antoine.tenart@...e-electrons.com> wrote: > >> Add support for the Berlin SoCs AHCI SATA controller allowing to > >> interface with devices like external hard drives. > > One more thing. > > >> + nports = readl(hpriv->mmio + HOST_PORTS_IMPL); > >> + > >> + /* force_map is modified only if the property is found */ > >> + of_property_read_u32(np, "marvell,force-port-map", &force_map); > > This property does not appear to be documented. I'll update it regarding Sebastian comments, or maybe drop it if it is possible to enable each port individually. > > >> + if (force_map) > >> + nports = force_map; > > You don't need this as your comment says, you can just do: > > of_property_read_u32(np, "marvell,force-port-map", &nports); > > nports will only be changed if property is present. Sure. Thanks! Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists