linux-kernel - Re: [PATCH 3/6] mfd: stmpe: prope properly from the device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdayYN73f+sQfr3bgTygWvUPDeDVp3kdzF39gnc++nS=qQ@mail.gmail.com>
Date:	Wed, 23 Apr 2014 10:52:47 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Silvio F <silvio.fricke@...il.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Shawn Guo <shawn.guo@...aro.org>,
	Viresh Kumar <viresh.linux@...il.com>,
	Shiraz Hashim <shiraz.hashim@...com>,
	spear-devel <spear-devel@...t.st.com>
Subject: Re: [PATCH 3/6] mfd: stmpe: prope properly from the device tree

On Thu, Apr 17, 2014 at 12:44 PM, Lee Jones <lee.jones@...aro.org> wrote:

>> +#ifdef CONFIG_OF
>
> Didn't you say that the only platform using this device is DT only? So
> why don't we make the driver depend on OF and get rid of this ugly
> #ifdeffery?

OK fixing.

>> +     {
>> +             .compatible = "st,stmpe2403",
>> +             .data = (void *)STMPE2403,
>> +     },
>> +     {},
>> +};
>
> If none of these stray over 80 chars, I think I'd like to see
> of_device_id tables as single line entries

OK.

>> +     if (partnum < 0)
>> +             partnum = id->driver_data;
>
> Should this be able to fail and for us to still carry on?

Actually yes, to stay compatible with elder device trees that use
the trick to just have the node name correspond to the I2C ID
instead of using compatible, this needs to be preserved. But I'll
add a small nag print about it.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/