linux-kernel - Re: [PATCH v3 0/3] staging: gdm72xx: Minor cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140423090557.GU26890@mwanda>
Date:	Wed, 23 Apr 2014 12:05:57 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Michalis Pappas <mpappas@...tmail.fm>
Cc:	devel@...verdev.osuosl.org, Greg KH <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/3] staging: gdm72xx: Minor cleanup

On Wed, Apr 23, 2014 at 04:49:26PM +0800, Michalis Pappas wrote:
> Hi Dan, thanks for looking at this. From the above snippet I realize
> that I wasn't aware of the strict flag, so significantly less errors
> were produced.
> 
> The issues I was referring to as pedantic are:
> 
> WARNING: unchecked sscanf return value
> #296: FILE: gdm_wimax.c:296:
> +               sscanf(e->dev->name, "wm%d", &idx);
> 
> does this really need to be checked?

Just check it.  The code as is looks like a information leak (security
vulnerability) until you realize that e->dev->name is probably a known,
trusted string.

> 
> ERROR: Macros with complex values should be enclosed in parenthesis
> #34: FILE: usb_ids.h:34:
> +#define USB_DEVICE_BOOTLOADER(vid, pid)	\
> +	{USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD)},	\
> +	{USB_DEVICE((vid), ((pid)&BL_PID_MASK)|B_DOWNLOAD|B_DIFF_DL_DRV)}
> 
> these macros are only used for brevity in a subsequent array
> declaration, so it seems that the parenthesis are not really needed.

Yeah.  You're right.  Just ignore this one.  Adding parenthis will break
the build.

checkpatch doesn't totally need to be happy.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/