linux-kernel - Re: [PATCH 2/2 v4] staging: comedi: addi_apci_1564: tidy up apci1564

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <53579A4F.6010108@mev.co.uk>
Date:	Wed, 23 Apr 2014 11:47:43 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Chase Southwood <chase.southwood@...oo.com>,
	<gregkh@...uxfoundation.org>
CC:	<hsweeten@...ionengravers.com>, <devel@...verdev.osuosl.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2 v4] staging: comedi: addi_apci_1564: tidy up apci1564_reset()

On 2014-04-17 07:33, Chase Southwood wrote:
> The reset function for this driver is a bit of a mess; clean it up to
> ensure that it is functioning properly.
>
> Signed-off-by: Chase Southwood <chase.southwood@...oo.com>
> ---
> 2: *Changed order of register accesses for digital input registers back to
> original ordering.
> *Removed read of digital output status register and reordered the accesses
> of digital output registers to agree with the order found in addi_apci_2032.
> *Fixed copy/paste error in the counter register reset lines.
>
> 3: *Returned the reset callback to the boardinfo...oops.
> *Don't write APCI1564_DO_IRQ_REG (it's read only).
> *Don't clear counter reload values...counters have already been
> disabled.
>
> 4: Leave this in hwdrv_apci1564.c for now (it can be moved after separating
> this driver from addi_common.c)
>
> NB: This patch has been renamed in this version.  It was previously known
> as "staging: comedi: addi_apci_1564: fixup and absorb apci1564_reset()"
>
>   .../comedi/drivers/addi-data/hwdrv_apci1564.c      | 24 ++++++++++++++--------
>   1 file changed, 15 insertions(+), 9 deletions(-)

Looks okay and it addresses the concerns raised by Hartley.

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/