linux-kernel - Re: [PATCH 3.8 110/133] nfsd4: fix memory leak in nfsd4_encode_fattr()

Open Source and information security mailing list archives

Message-ID: <20140423105633.GB3572@hercules>
Date:	Wed, 23 Apr 2014 11:56:33 +0100
From:	Luis Henriques <luis.henriques@...onical.com>
To:	Kamal Mostafa <kamal@...onical.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	kernel-team@...ts.ubuntu.com, "Yan, Zheng" <zheng.z.yan@...el.com>,
	"J. Bruce Fields" <bfields@...hat.com>
Subject: Re: [PATCH 3.8 110/133] nfsd4: fix memory leak in
 nfsd4_encode_fattr()

Hi Kamal,

On Tue, Apr 22, 2014 at 01:14:08PM -0700, Kamal Mostafa wrote:
> 3.8.13.22 -stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: "Yan, Zheng" <zheng.z.yan@...el.com>
> 
> commit 18df11d0eacf67bbcd8dda755b568bbbd7264735 upstream.
> 
> fh_put() does not free the temporary file handle.
> 
> Signed-off-by: Yan, Zheng <zheng.z.yan@...el.com>
> Signed-off-by: J. Bruce Fields <bfields@...hat.com>
> [ kamal: backport to 3.8 (context) ]
> Signed-off-by: Kamal Mostafa <kamal@...onical.com>
> ---
>  fs/nfsd/nfs4xdr.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index dc12d02..1418028 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -2430,8 +2430,10 @@ out_acl:
>  
>  out:
>  	kfree(acl);
> -	if (fhp == &tempfh)
> +	if (fhp == &tempfh) {
>  		fh_put(&tempfh);
> +		kfree(tempfh);

This doesn't look correct to me as in 3.8 kernel the tempfh variable
is a 'struct svc_fh' and not a dynamically allocated structure.

This has changed only with commit d50e613 "nfsd4: decrease
nfsd4_encode_fattr stack usage", where tempfh was converted into a
'struct svc_fh *'.

So, I believe you should drop this patch from 3.8.

Cheers,
--
Luís

> +	}
>  	return status;
>  out_nfserr:
>  	status = nfserrno(err);
> -- 
> 1.9.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@...ts.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives