linux-kernel - Re: [PATCH] proc: fix documentation for /proc/stat, line "intr"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5357B6B4.6020008@gmail.com>
Date:	Wed, 23 Apr 2014 14:48:52 +0200
From:	"Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
To:	Jan Moskyto Matejka <mq@...e.cz>,
	Randy Dunlap <rdunlap@...radead.org>
CC:	mtk.manpages@...il.com, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] proc: fix documentation for /proc/stat, line "intr"

On 04/23/2014 11:48 AM, Jan Moskyto Matejka wrote:
> n Tue, Apr 22, 2014 at 03:35:39PM -0700, Randy Dunlap wrote:
>> On 04/22/14 11:19, Michael Kerrisk (man-pages) wrote:
>>> On 04/22/2014 05:29 PM, Jan Moskyto Matejka wrote:
>>>> The sum at the beginning of line "intr" includes also unnumbered interrupts.
>>>> It implies that the sum at the beginning isn't the sum of the remainder of the
>>>> line, not even an estimation.
>>>>
>>>> Fixed the documentation to mention that.
>>>
>>> I'm not really doubting what you claim, Jan, but it would be really
>>> helpful if you provided some data to support the proposed change
>>> (Kernel source references, or notes about testing you've done, or 
>>> pointers to mailing list threads, authoritative note that you are
>>> the maintainer of some relevant kernel subsystem...). Do you have
>>> something like that? (It's also useful for the change log.)
>>
>> I wouldn't mind more of a changelog, but the additional text is
>> certainly correct.
>>
>> Thanks.  I'll apply the patch, but more changelog comments are welcome.
> 
> Thank you for applying.
> 
> You may add following line to the changelog:
> This behaviour was added to /proc/stat in commit a2eddfa95919a730e0e5ed17e9c303fe5ba249cd.

Thanks, Jan -- that's indeed helpful for the man-pages changelog!


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/