linux-kernel - Re: [PATCH v6 15/19] usb: phy: msm: Fix PTS definitions for MSM USB controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1398259477.4724.218.camel@iivanov-dev>
Date:	Wed, 23 Apr 2014 16:24:37 +0300
From:	"Ivan T. Ivanov" <iivanov@...sol.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Felipe Balbi <balbi@...com>, Tim Bird <tbird20d@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, Tim Bird <tim.bird@...ymobile.com>
Subject: Re: [PATCH v6 15/19] usb: phy: msm: Fix PTS definitions for MSM USB
 controller

Hi,

On Tue, 2014-04-22 at 17:09 +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 22-04-2014 13:20, Ivan T. Ivanov wrote:
> 
> > From: Tim Bird <tbird20d@...il.com>
> 
> > Fix the value used for Parallel Transceiver Select (PTS) for the MSM USB
> > controller.  This is a standard chipidea PORTSC definition, where
> > a PHY_TYPE of 10b (<<30) is ULPI and 11b (<<30) is SERIAL.
> > Fix the definitions and use them correctly in the driver code.
> 
> > Signed-off-by: Tim Bird <tim.bird@...ymobile.com>
> > ---
> >   drivers/usb/phy/phy-msm-usb.c    | 8 +++++---
> >   include/linux/usb/msm_hsusb_hw.h | 5 +++--
> >   2 files changed, 8 insertions(+), 5 deletions(-)
> 
> > diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
> > index dababf9..e83d13a 100644
> > --- a/drivers/usb/phy/phy-msm-usb.c
> > +++ b/drivers/usb/phy/phy-msm-usb.c
> > @@ -287,8 +287,9 @@ static int msm_link_reset(struct msm_otg *motg)
> >   	if (motg->phy_number)
> >   		writel(readl(USB_PHY_CTRL2) | BIT(16), USB_PHY_CTRL2);
> >
> > +	/* put transciever in serial mode as part of reset */
> 
>     s/transciever/transceiver/
> 
> [...]
> 
> > diff --git a/include/linux/usb/msm_hsusb_hw.h b/include/linux/usb/msm_hsusb_hw.h
> > index 575c743..98d3dd8 100644
> > --- a/include/linux/usb/msm_hsusb_hw.h
> > +++ b/include/linux/usb/msm_hsusb_hw.h
> > @@ -31,8 +31,9 @@
> >   #define USB_USBINTR          (MSM_USB_BASE + 0x0148)
> >
> >   #define PORTSC_PHCD            (1 << 23) /* phy suspend mode */
> > -#define PORTSC_PTS_MASK         (3 << 30)
> > -#define PORTSC_PTS_ULPI         (3 << 30)
> > +#define PORTSC_PTS_MASK        (3 << 30)
> > +#define PORTSC_PTS_ULPI        (2 << 30)
> > +#define PORTSC_PTS_SERIAL      (3 << 30)
> 
>     Please use tabs, not spaces here.

Thanks, will fix and resend.

Ivan

> 
> WBR, Sergei
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/