linux-kernel - Re: [PATCH] cpufreq: powernow-k8: Fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Apr 2014 16:51:58 +0300
From:	Stratos Karafotis <stratosk@...aphore.gr>
To:	Viresh Kumar <viresh.kumar@...aro.org>
CC:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	"cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: powernow-k8: Fix checkpatch warnings

On 23/04/2014 07:46 πμ, Viresh Kumar wrote:
> On 23 April 2014 02:43, Stratos Karafotis <stratosk@...aphore.gr> wrote:
>> @@ -342,7 +333,7 @@ static int core_voltage_pre_transition(struct powernow_k8_data *data,
>>                 return 1;
>>
>>         if (savefid != data->currfid) {
>> -               printk(KERN_ERR PFX "ph1 err, currfid changed 0x%x\n",
>> +               pr_err("ph1 err, currfid changed 0x%x\n",
>>                                 data->currfid);
> 
> This will come in single line?
> 
>> @@ -529,43 +510,39 @@ static int check_pst_table(struct powernow_k8_data *data, struct pst_s *pst,
>>
>>         for (j = 0; j < data->numps; j++) {
>>                 if (pst[j].vid > LEAST_VID) {
>> -                       printk(KERN_ERR FW_BUG PFX "vid %d invalid : 0x%x\n",
>> -                              j, pst[j].vid);
>> +                       pr_err(FW_BUG "vid %d invalid : 0x%x\n", j,
>> +                              pst[j].vid);
> 
> Same here.
> 
>>  static const char missing_pss_msg[] =
>>         KERN_ERR
> 
> remove this and use pr_err_once instead of printk_once()
> 
>> -       FW_BUG PFX "No compatible ACPI _PSS objects found.\n"
>> -       FW_BUG PFX "First, make sure Cool'N'Quiet is enabled in the BIOS.\n"
>> -       FW_BUG PFX "If that doesn't help, try upgrading your BIOS.\n";
>> +       FW_BUG KBUILD_MODNAME
>> +       "No compatible ACPI _PSS objects found.\n"
> 
> Don't break these, even if they cross 80 columns.
> 

Thanks for your review!

Stratos

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/