linux-kernel - Re: [GIT PULL] regulator: First pull of MFD <-> Regulator IB (v3.16)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Apr 2014 16:00:47 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Mark Brown <broonie@...nel.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] regulator: First pull of MFD <-> Regulator IB (v3.16)

> > Doug Anderson (3):
> >       mfd: tps65090: Don't tell child devices we have an IRQ if we don't
> >       mfd: tps65090: Stop caching most registers
> >       regulator: tps65090: Allow setting the overcurrent wait time
> 
> Can you drop the last one please, I've already applied it?  I'd have
> expected just the first two (or probably even just the second one).  If
> you need it in your tree just grab the branch (or I can tag it if you
> like).
> 
> I tend to apply these things early where they don't have dependencies
> due to the large number of reposts for unrelated changes in the series
> that tend to happen (and often several very similar serieses being in
> flight at once); I frequently end up just deleting them unread.  Not
> sure what the best way to handle this stuff is in general.

I know that you due, which I think makes things easier for you, but
more difficult for everyone else (author, other maintainers). Applying
cross-subsystem patches also makes things difficult down the line.

Not sure what do do about the last patch now, as it has MFD changes
which aren't in the MFD tree. All well and good if no one else touches
that hunk for the remainder of the cycle, but if they do we're likely
to have merge conflicts.

I'll re-spin Monday.

> >  Documentation/devicetree/bindings/regulator/tps65090.txt |  4 ++++
> >  drivers/mfd/tps65090.c                                   | 41 +++++++++++++++++++++++++----------------
> >  drivers/power/tps65090-charger.c                         | 11 -----------
> >  drivers/regulator/tps65090-regulator.c                   | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/tps65090.h                             | 19 +++++++++++++++++++
> >  5 files changed, 104 insertions(+), 27 deletions(-)
> 
> Your formatting for these still seems to be messing up.

How so? Looks fine for me I think?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/