linux-kernel - Re: [PATCH 08/13] tty: serial: omap: switch over to platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140423154927.GK9593@saruman.home>
Date:	Wed, 23 Apr 2014 10:49:27 -0500
From:	Felipe Balbi <balbi@...com>
To:	Fabio Estevam <festevam@...il.com>,
	Tony Lindgren <tony@...mide.com>
CC:	Felipe Balbi <balbi@...com>, Greg KH <gregkh@...uxfoundation.org>,
	Marcel Holtmann <marcel@...tmann.org>, <gustavo@...ovan.org>,
	<johan.hedberg@...il.com>, <jslaby@...e.cz>,
	Grant Likely <grant.likely@...aro.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	<linux-bluetooth@...r.kernel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
	Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH 08/13] tty: serial: omap: switch over to
 platform_get_resource

On Wed, Apr 23, 2014 at 12:27:59PM -0300, Fabio Estevam wrote:
> On Wed, Apr 23, 2014 at 11:58 AM, Felipe Balbi <balbi@...com> wrote:
> 
> > @@ -1658,12 +1657,9 @@ static int serial_omap_probe(struct platform_device *pdev)
> >                 omap_up_info = of_get_uart_port_info(&pdev->dev);
> >                 pdev->dev.platform_data = omap_up_info;
> >         } else {
> > -               irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> > -               if (!irq) {
> > -                       dev_err(&pdev->dev, "no irq resource?\n");
> > -                       return -ENODEV;
> > -               }
> > -               uartirq = irq->start;
> > +               uartirq = platform_get_irq(pdev, 0);
> > +               if (uartirq < 0)
> > +                       return -EPROBE_DEFER;
> 
> 
> Maybe you could just do a 'return uartirq' here instead.

I don't mind either way, I'm only returning -EPROBE_DEFER because that's
what the other branch of this conditional returns. Tony, what do you
prefer ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)