linux-kernel - RE: [PATCH 2/2 v4] staging: comedi: addi_apci_1564: tidy up apci1564

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 23 Apr 2014 16:25:31 +0000
From:	Hartley Sweeten <HartleyS@...ionengravers.com>
To:	Chase Southwood <chase.southwood@...oo.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	"abbotti@....co.uk" <abbotti@....co.uk>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2 v4] staging: comedi: addi_apci_1564: tidy up
 apci1564_reset()

On Wednesday, April 23, 2014 12:09 AM, Chase Southwood wrote:
>>On Thursday, April 17, 2014 1:33 AM, Chase Southwood <chase.southwood@...oo.com> wrote:
>
>> The reset function for this driver is a bit of a mess; clean it up to
>> ensure that it is functioning properly.
>>
>> Signed-off-by: Chase Southwood <chase.southwood@...oo.com>
>> ---
>> 2: *Changed order of register accesses for digital input registers back to
>> original ordering.
>> *Removed read of digital output status register and reordered the accesses
>> of digital output registers to agree with the order found in addi_apci_2032.
>> *Fixed copy/paste error in the counter register reset lines.
>>
>> 3: *Returned the reset callback to the boardinfo...oops.
>> *Don't write APCI1564_DO_IRQ_REG (it's read only).
>> *Don't clear counter reload values...counters have already been
>> disabled.
>>
>> 4: Leave this in hwdrv_apci1564.c for now (it can be moved after separating
>> this driver from addi_common.c)
>>
>>NB: This patch has been renamed in this version.  It was previously known
>>as "staging: comedi: addi_apci_1564: fixup and absorb apci1564_reset()"
>>
>
>
> Ian and Hartley,
>
> Just following up to see if you have any comments on this version of this patch.
> PATCH 1/2 from this set was added to staging-next today, and I'd like to know
> where this one stands before I work on separating this driver from addi_common.c.
> I'd be happy to make any more changes that are desired, or if it's just better to
> drop the patch for now, that's ok too.  Just want to make sure it's taken care of
> before I move on!

Sorry, I thought I already responded to this...

Looks good now.

Reviewed-by: H Hartley Sweeten <hsweeten@...ionengravers.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/