lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Apr 2014 18:46:57 +0200 From: Tomasz Figa <t.figa@...sung.com> To: linux-pm@...r.kernel.org Cc: linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rjw@...ysocki.net>, Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>, Russell King <linux@....linux.org.uk>, Kukjin Kim <kgene.kim@...sung.com>, Kumar Gala <galak@...eaurora.org>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Mark Rutland <mark.rutland@....com>, Pawel Moll <pawel.moll@....com>, Rob Herring <robh+dt@...nel.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Stephen Warren <swarren@...dotorg.org>, Mark Brown <broonie@...nel.org>, Stephen Boyd <sboyd@...eaurora.org>, Lorenzo Pieralisi <lorenzo.pieralisi@....com>, Ulf Hansson <ulf.hansson@...aro.org>, Marek Szyprowski <m.szyprowski@...sung.com>, Tomasz Figa <tomasz.figa@...il.com>, Kevin Hilman <khilman@...aro.org>, Philipp Zabel <philipp.zabel@...il.com>, Tomasz Figa <t.figa@...sung.com> Subject: [PATCH v3 2/3] drivercore: Bind/unbind power domain on probe/remove On a number of platforms, devices are part of controllable power domains, which need to be enabled before such devices can be accessed and may be powered down when the device is idle to save some power. This means that on systems that support power domain control using generic power domains subsystem, it is necessary to add device to its power domain before binding a driver to it and remove it from its power domain after its driver is unbound to make sure that an unused device does not affect power domain state. Since this is not limited to particular busses and specific archs/platforms, it is more convenient to do the above directly in driver core, just as done with pinctrl default configuration. This patch adds necessary code to really_probe() and __device_release_driver() to achieve this and maintain consistent stack-like ordering of operations happening when binding and unbinding a driver. Signed-off-by: Tomasz Figa <t.figa@...sung.com> Reviewed-by: Stephen Boyd <sboyd@...eaurora.org> Reviewed-by: Philipp Zabel <philipp.zabel@...il.com> [on i.MX6 GK802] Tested-by: Philipp Zabel <philipp.zabel@...il.com> Reviewed-by: Mark Brown <broonie@...aro.org> Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org> --- drivers/base/dd.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 8986b9f..7501c42 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -23,6 +23,7 @@ #include <linux/kthread.h> #include <linux/wait.h> #include <linux/async.h> +#include <linux/pm_domain.h> #include <linux/pm_runtime.h> #include <linux/pinctrl/devinfo.h> @@ -273,6 +274,11 @@ static int really_probe(struct device *dev, struct device_driver *drv) dev->driver = drv; + /* If using genpd, bind power domain now before probing */ + ret = genpd_bind_domain(dev); + if (ret) + goto probe_failed; + /* If using pinctrl, bind pins now before probing */ ret = pinctrl_bind_pins(dev); if (ret) @@ -303,6 +309,7 @@ static int really_probe(struct device *dev, struct device_driver *drv) probe_failed: devres_release_all(dev); driver_sysfs_remove(dev); + genpd_unbind_domain(dev); dev->driver = NULL; dev_set_drvdata(dev, NULL); @@ -513,7 +520,7 @@ static void __device_release_driver(struct device *dev) blocking_notifier_call_chain(&dev->bus->p->bus_notifier, BUS_NOTIFY_UNBOUND_DRIVER, dev); - + genpd_unbind_domain(dev); } } -- 1.9.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists