linux-kernel - Re: [PATCH] net/phy: micrel: fix bugged test on device tree loading for ksz9021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140423.145926.998744821096383568.davem@davemloft.net>
Date:	Wed, 23 Apr 2014 14:59:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	hchaumette@...neo-embedded.com
Cc:	f.fainelli@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH] net/phy: micrel: fix bugged test on device tree
 loading for ksz9021

From: Hubert Chaumette <hchaumette@...neo-embedded.com>
Date: Tue, 22 Apr 2014 15:01:04 +0200

> In ksz9021_load_values_from_of() val2 to val4 aren't tested against their
> initialization value.
> This causes the test to always succeed, and this value to be used as if it
> was loaded from the devicetree instead of being ignored, in case of a
> missing/invalid property in the ethernet OF device node.
> As a result, the value "0" is written to the relevant registers.
> 
> Change the conditions to test against the right initialization value.
> 
> Signed-off-by: Hubert Chaumette <hchaumette@...neo-embedded.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/