linux-kernel - Re: linux-next: build failure after merge of the vfs tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140423103321.b936dc0700263bbaf617d03d@canb.auug.org.au>
Date:	Wed, 23 Apr 2014 10:33:21 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: linux-next: build failure after merge of the vfs tree

Hi Al,

On Tue, 22 Apr 2014 11:26:53 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> After merging the vfs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> fs/nfs/direct.c: In function 'nfs_direct_read_schedule_iovec':
> fs/nfs/direct.c:382:4: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>     vfree(pagevec);
>     ^
> 
> Caused by commit 2703e4cd2d57 ("new helper: iov_iter_get_pages_alloc()").
> 
> I have used the vfs tree from next-20140417 for today.

With mixed feelings, I have added the following patch for today:

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Wed, 23 Apr 2014 10:29:35 +1000
Subject: [PATCH] vfs: using vfree requires including vmalloc.h

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 fs/nfs/direct.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
index 775cc5031eea..9116d9a49406 100644
--- a/fs/nfs/direct.c
+++ b/fs/nfs/direct.c
@@ -47,6 +47,7 @@
 #include <linux/slab.h>
 #include <linux/task_io_accounting_ops.h>
 #include <linux/module.h>
+#include <linux/vmalloc.h>
 
 #include <linux/nfs_fs.h>
 #include <linux/nfs_page.h>
-- 
1.9.2

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped