| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Apr 2014 00:49:46 +0200
From: Antoine Ténart
<antoine.tenart@...e-electrons.com>
To: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc: Mike Turquette <mturquette@...aro.org>,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
Subject: Re: [PATCH 5/5] ARM: berlin/dt: add sdio clocks to BG2Q
Alexandre,
On Wed, Apr 23, 2014 at 04:01:07PM +0200, Alexandre Belloni wrote:
> Add sdio clocks to the berlin2q.dtsi
> Also reorder the syspll node
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> ---
> arch/arm/boot/dts/berlin2q.dtsi | 28 +++++++++++++++++++++-------
> 1 file changed, 21 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
> index 5925e6a16749..0fc826305614 100644
> --- a/arch/arm/boot/dts/berlin2q.dtsi
> +++ b/arch/arm/boot/dts/berlin2q.dtsi
> @@ -102,13 +102,6 @@
> reg = <0xdd0170 0x8>;
> };
>
> - syspll: syspll@...030 {
> - compatible = "marvell,berlin2q-pll";
> - clocks = <&smclk>;
> - #clock-cells = <0>;
> - reg = <0xea0030 0x8>;
> - };
> -
> apb@...000 {
> compatible = "simple-bus";
> #address-cells = <1>;
> @@ -191,6 +184,27 @@
> };
> };
>
> + syspll: syspll@...030 {
> + compatible = "marvell,berlin2q-pll";
> + clocks = <&smclk>;
> + #clock-cells = <0>;
> + reg = <0xea0030 0x8>;
> + };
> +
> + sdio0xinclk: sdio0xinclk@...158 {
> + compatible = "marvell,berlin-clk";
> + clocks = <&syspll>;
> + #clock-cells = <0>;
> + reg = <0xea0158 4>;
I believe you can use
reg = <0xea0158 0x4>;
since you used an hex value in the previous node. Plus we tend to use
hex values elsewhere too.
> + };
> +
> + sdio1xinclk: sdio1xinclk@...15c {
> + compatible = "marvell,berlin-clk";
> + clocks = <&syspll>;
> + #clock-cells = <0>;
> + reg = <0xea015c 4>;
Ditto. This also applies to BG2/BG2CD and the documentation patches.
Thanks!
Antoine
> + };
> +
> apb@...000 {
> compatible = "simple-bus";
> #address-cells = <1>;
> --
> 1.9.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists