linux-kernel - Re: [PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Apr 2014 07:49:08 +1000
From:	James Cameron <quozl@...top.org>
To:	Masanari Iida <standby24x7@...il.com>
Cc:	Larry.Finger@...inger.net, gregkh@...uxfoundation.org,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: rtl8192e: Fix typo in rtl8192e

On Fri, Apr 25, 2014 at 01:48:41AM +0900, Masanari Iida wrote:
> Fix spelling typo in comments within rtl8192e.
> 
> Signed-off-by: Masanari Iida <standby24x7@...il.com>
> ---
>  drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +-
>  drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c    | 2 +-
>  drivers/staging/rtl8192e/rtl8192e/rtl_wx.c        | 2 +-
>  drivers/staging/rtl8192e/rtl819x_TSProc.c         | 2 +-
>  drivers/staging/rtl8192e/rtllib_rx.c              | 2 +-
>  drivers/staging/rtl8192e/rtllib_softmac.c         | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 

...

> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> index 498995d..59494f5 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> @@ -1213,7 +1213,7 @@ static iw_handler r8192_wx_handlers[] = {
>  };
>  
>  /*
> - * the following rule need to be follwing,
> + * the following rule need to be following,
>   * Odd : get (world access),
>   * even : set (root access)
>   * */

The change is good, and a better change might be "s/rule/rules" and
"s/following/followed".

On the other hand, no other driver mentions this implementation detail
of IW_IS_SET in declaration of iw_priv_args, so perhaps the whole
comment block should be removed.

Either way;

Reviewed-by: James Cameron <quozl@...top.org>

p.s. nice to see you again.

-- 
James Cameron
http://quozl.linux.org.au/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/