linux-kernel - Re: [PATCH] printk: Print cpu number along with time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140424222046.GB4098@kroah.com>
Date:	Thu, 24 Apr 2014 15:20:46 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Jörn Engel <joern@...fs.org>,
	Rik van Riel <riel@...hat.com>, linux-kernel@...r.kernel.org,
	peterz@...radead.org, akpm@...ux-foundation.org, cxie@...hat.com,
	Jiri Slaby <jslaby@...e.cz>
Subject: Re: [PATCH] printk: Print cpu number along with time

On Fri, Apr 25, 2014 at 12:12:06AM +0200, Jiri Kosina wrote:
> On Thu, 24 Apr 2014, Greg Kroah-Hartman wrote:
> 
> > > +#ifdef CONFIG_PRINTK_CPU
> > > +	if (!buf)
> > > +		return snprintf(NULL, 0, "[%5lu.000000,%02x] ",
> > 
> > %02x for a cpu?  What happens on machines with 8k cpus?
> 
> Ummm ... what issue do you see here, Greg? It'll print 0x1f40, no?

Yes, just not be as "pretty" and aligned properly :)

> > And is this really an issue?  Debugging by using printk is fun, but not 
> > really something that people need to add a cpu number to.  Why not just 
> > use a tracepoint in your code to get the needed information instead?
> 
> Well, if you have dmesg dump from panic that happens every other year, and 
> you have to do post-mortem analysis on it, I am pretty sure you would love 
> to be able to figure out how the stack traces would look like without 
> inter-CPU interleaving. And I am pretty sure you wouldn't want to 
> insert/enable a tracepoint and wait another two years for the bug to 
> trigger again.

Fair enough, and the multi-oops message drives that home.

But does this break things like 'dmesg --human' mode that is in
util-linux?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/