linux-kernel - Re: [PATCH] mmc: core: Try other signal levels during power up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Apr 2014 10:38:50 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Tim Kryger <tim.kryger@...aro.org>
Cc:	Chris Ball <chris@...ntf.net>,
	Linux MMC <linux-mmc@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: core: Try other signal levels during power up

On 18 April 2014 20:58, Tim Kryger <tim.kryger@...aro.org> wrote:
> The eMMC signalling voltage is determined by VCCQ which is provided to
> the card by the host.  Signalling is not required to begin at 3.3v and,
> if the host and card both support a particular VCC/VCCQ combination, it
> can be used immediately.
>
> In contrast, SD Cards must begin with 3.3v signalling and may switch to
> a lower voltage signalling if instructed to do so in CMD11.  A message
> is required to coordinate this operation because the card only receives
> a 3.3v VDD and must know when to use the 1.8v produced by its internal
> regulator.
>
> It makes sense for the core to begin with 3.3v signalling but when that
> can't be set, 1.8v and 1.2v signalling also should be attempted.  This
> is especially important when an external regulator with a limited range
> is used to supply VCCQ to an eMMC part.
>
> Signed-off-by: Tim Kryger <tim.kryger@...aro.org>
> ---
>  drivers/mmc/core/core.c |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index acbc3f2..ecdbeae 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -1517,6 +1517,8 @@ void mmc_set_driver_type(struct mmc_host *host, unsigned int drv_type)
>   */
>  void mmc_power_up(struct mmc_host *host, u32 ocr)
>  {
> +       int err;
> +

The variable err is not needed, since we don't plan on printing it nor
returning it. Please remove and handle the return code directly in the
if statements.

Kind regards
Ulf Hansson

>         if (host->ios.power_mode == MMC_POWER_ON)
>                 return;
>
> @@ -1534,7 +1536,13 @@ void mmc_power_up(struct mmc_host *host, u32 ocr)
>         mmc_set_ios(host);
>
>         /* Set signal voltage to 3.3V */
> -       __mmc_set_signal_voltage(host, MMC_SIGNAL_VOLTAGE_330);
> +       err = __mmc_set_signal_voltage(host, MMC_SIGNAL_VOLTAGE_330);
> +
> +       /* Since eMMC parts can start at 1.8v or 1.2v try those too */
> +       if (err)
> +               err = __mmc_set_signal_voltage(host, MMC_SIGNAL_VOLTAGE_180);
> +       if (err)
> +               __mmc_set_signal_voltage(host, MMC_SIGNAL_VOLTAGE_120);
>
>         /*
>          * This delay should be sufficient to allow the power supply
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/