linux-kernel - Re: [PATCH] mmc: dw_mmc: Don't print data errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFo7Mi9+WJx+7rcB_fqdi59TuY+FhT=Ued9Zi=rhNGnYtA@mail.gmail.com>
Date:	Thu, 24 Apr 2014 11:14:51 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Doug Anderson <dianders@...omium.org>
Cc:	Seungwon Jeon <tgih.jun@...sung.com>,
	Jaehoon Chung <jh80.chung@...sung.com>,
	Yuvaraj Kumar C D <yuvaraj.cd@...sung.com>,
	Alim Akhtar <alim.akhtar@...sung.com>,
	Sonny Rao <sonnyrao@...omium.org>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	Chris Ball <chris@...ntf.net>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: dw_mmc: Don't print data errors

>> The "status" here could be useful information about the status
>> register, which is not considered while printing errors by the "higher
>> levels". An option could be to print the error, but not when you
>> perform tuning.
>>
>> No big deal though, just a thought.
>
> Right, I could potentially put the driver into "tuning" mode and then
> suppress the errors during that time.  If you request it I will do
> that.
>
> I will also note that there are many other error conditions in the
> driver that don't have such printouts.  I think the general philosophy
> of this driver is not to print them...

So, then let's stick to that philosophy and keep this as is.

Kind regards
Ulf Hansson

>
> -Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/