linux-kernel - [PATCH] ignore ,keep for efi earlyprintk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140424093658.GA7158@dhcp-16-198.nay.redhat.com>
Date:	Thu, 24 Apr 2014 17:36:58 +0800
From:	Dave Young <dyoung@...hat.com>
To:	matt.fleming@...el.com, hpa@...or.com, akpm@...ux-foundation.org,
	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] ignore ,keep for efi earlyprintk

earlyprint=efi,keep results a kernel hang after "Freeing unused kernel memory"

Actually efi earlyprintk is using __init functions such as early_ioremap etc.
Thus efi earlyconsole can not be kept.

So just ignore it and give out a warning to user.

Signed-off-by: Dave Young <dyoung@...hat.com>
---
 arch/x86/kernel/early_printk.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Index: linux-2.6/arch/x86/kernel/early_printk.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/early_printk.c
+++ linux-2.6/arch/x86/kernel/early_printk.c
@@ -237,8 +237,11 @@ static int __init setup_early_printk(cha
 		}
 #endif
 #ifdef CONFIG_EARLY_PRINTK_EFI
-		if (!strncmp(buf, "efi", 3))
-			early_console_register(&early_efi_console, keep);
+		if (!strncmp(buf, "efi", 3)) {
+			if (keep)
+				pr_warn("Ignoring ,keep for earlyprintk=efi\n");
+			early_console_register(&early_efi_console, 0);
+		}
 #endif
 
 		buf++;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/