linux-kernel - Re: [PATCH v2] dma: imx-sdma: add support for sdma memory copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140424094537.GA26556@Robin-OptiPlex-780>
Date:	Thu, 24 Apr 2014 17:45:42 +0800
From:	Robin Gong <b38343@...escale.com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:	<vinod.koul@...el.com>, <dan.j.williams@...el.com>,
	<dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] dma: imx-sdma: add support for sdma memory copy

On Thu, Apr 24, 2014 at 11:50:06AM +0300, Andy Shevchenko wrote:
> On Thu, 2014-04-24 at 13:09 +0800, Robin Gong wrote:
> > add "device_prep_dma_memcpy" and "device_prep_dma_sg" for memory copy by sdma.
> > 
> > Signed-off-by: Robin Gong <b38343@...escale.com>
> > 
> > ---
> > change:
> > --v2:
> >   1. correct some printk format, such as %pad for dma_addr_t
> >   2. split duplicated code in prep_dma_memcpy and prep_dma_sg to make code clean.
> 
> Thanks for an update. One small comment below.
> 
> > +
> > +static int check_bd_buswidth(struct sdma_buffer_descriptor *bd,
> > +			     struct sdma_channel *sdmac, int count,
> > +			     dma_addr_t dma_dst, dma_addr_t dma_src)
> > +{
> > +	int ret = 0;
> > +
> > +	if (sdmac->word_size > DMA_SLAVE_BUSWIDTH_4_BYTES)
> > +		ret =  -EINVAL;
> 
> I think two lines above are redundant since you have default path in the
> switch.
>
Thanks, will remove it in next version.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/