lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1398329653-29968-1-git-send-email-fercerpav@gmail.com>
Date:	Thu, 24 Apr 2014 12:54:13 +0400
From:	Paul Fertser <fercerpav@...il.com>
To:	Li Yang <leoli@...escale.com>, Felipe Balbi <balbi@...com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Paul Fertser <fercerpav@...il.com>
Subject: [PATCH] usb: gadget: fsl: check vbus presence on probe

If VBUS is already present during the driver initialisation, the
corresponding IRQ never fires, so there is no way the gadget can get
enumerated.

This patch is real-life tested on an i.MX25 board with VBUS constantly
hooked up.

Signed-off-by: Paul Fertser <fercerpav@...il.com>
---
 drivers/usb/gadget/fsl_udc_core.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c
index a2f26cd..b4b1516 100644
--- a/drivers/usb/gadget/fsl_udc_core.c
+++ b/drivers/usb/gadget/fsl_udc_core.c
@@ -2501,6 +2501,11 @@ static int __init fsl_udc_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_del_udc;
 
+	/* Now let it settle a bit and sense VBUS */
+	msleep_interruptible(1);
+	if (fsl_readl(&dr_regs->otgsc) & OTGSC_STS_B_SESSION_VALID)
+		udc_controller->vbus_active = 1;
+
 	create_proc_file();
 	return 0;
 
-- 
1.7.10

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ