[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140424113438.GB1110@krava.brq.redhat.com>
Date: Thu, 24 Apr 2014 13:34:38 +0200
From: Jiri Olsa <jolsa@...hat.com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Ingo Molnar <mingo@...nel.org>,
Paul Mackerras <paulus@...ba.org>,
Namhyung Kim <namhyung.kim@....com>,
LKML <linux-kernel@...r.kernel.org>,
David Ahern <dsahern@...il.com>,
Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCHSET 00/11] perf tools: Fixup for the --percentage change
(v3)
On Thu, Apr 24, 2014 at 05:23:52PM +0900, Namhyung Kim wrote:
SNIP
>
> So yes, it has a same problem of inaccurate number of samples, but its
> impact should be smaller than other stats - seeing increasing sample
> count (could be slightly inaccurate) without new entries in the browser.
>
> * changes in v3)
> - split patch 2/7 into parts (Jiri)
> - fix a segfault when filtering with unfolded entry (Jiri)
other than my comment for patch 4 it seems ok to me
thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists