linux-kernel - Re: [PATCH 1/1] uprobes/tracing: uprobe_perf_open() forgets to handle the error from uprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Apr 2014 14:27:21 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Anton Arapov <aarapov@...hat.com>,
	David Long <dave.long@...aro.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] uprobes/tracing: uprobe_perf_open() forgets to
	handle the error from uprobe_apply()

On 04/24, Srikar Dronamraju wrote:
>
> Acked-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>

Thanks, included!

> > +		tu->filter.nr_systemwide--;
> >  		done = tu->filter.nr_systemwide;
> > -		tu->filter.nr_systemwide++;
> >  	}
>
> Nit: I think 2 lines can be made into
>  done = --tu->filter.nr_systemwide;
...
> > -		tu->filter.nr_systemwide--;
> >  		done = tu->filter.nr_systemwide;
> > +		tu->filter.nr_systemwide++;
> >  	}
>
> Nit: Similarly lines can be made into
>  done = tu->filter.nr_systemwide++;

Yes, perhaps, but this has nothing to do with this patch, it does not
change this code.

And can't resist... you know, initially I wrote this code this way, but
then I decided to make it more straightforward to avoid the potential nits
from reviewers ;)

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/