linux-kernel - Re: [PATCH] pinctrl-baytrail: fix for irq descriptor conflict on ASUS T100TA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5359120E.2030007@linux.intel.com>
Date:	Thu, 24 Apr 2014 21:30:54 +0800
From:	"Jin, Yao" <yao.jin@...ux.intel.com>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Adam Williamson <awilliam@...hat.com>
CC:	Benjamin Tissoires <benjamin.tissoires@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>, alan@...ux.intel.com,
	mathias.nyman@...el.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl-baytrail: fix for irq descriptor conflict on
 ASUS T100TA



On 2014/4/23 20:23, Mika Westerberg wrote:
> On Wed, Apr 23, 2014 at 11:34:30AM +0300, Mika Westerberg wrote:
>> On Tue, Apr 22, 2014 at 10:16:50PM -0700, Adam Williamson wrote:
>>> Well, I can't actually concur. See my results in
>>> https://bugzilla.kernel.org/show_bug.cgi?id=68291#c44 .
>>>
>>> 1. A kernel with neither patch applied (and no hid-rmi driver) results
>>> in a working touchscreen.
>>> 2. A kernel with only v3 of Doug's patch from
>>> https://bugzilla.kernel.org/show_bug.cgi?id=67921 results in a working
>>> touchscreen.
>>> 3. A kernel with both v3 of Doug's patch and this IRQ descriptor
>>> conflict "fix" results in a broken touchscreen.
>>>
>>> Seems to me there really is some kind of problem with this patch...
>>
>> Can you try so that you have both patches applied and then this one? I'm
>> suspecting that the ACPI GPIO operation region support might do something
>> unexpected in this case.
> 
> I'm able to reproduce this problem here now and it seems not related to the
> ACPI GPIO operation regions.
> 
> This patch changes call to irq_domain_add_linear() to
> irq_domain_add_simple() and somehow that changes the behaviour so that I
> get non-working touchscreen:
> 
> ...
> [   37.434998] i2c_hid i2c-ATML1000:00: failed to reset device.
> [   37.435009] i2c_hid i2c-ATML1000:00: i2c_hid_set_power
> [   37.435021] i2c_hid i2c-ATML1000:00: __i2c_hid_command: cmd=fb 00 01 08
> [   38.439897] i2c_hid i2c-ATML1000:00: can't add hid device: -61
> [   38.440749] i2c_hid: probe of i2c-ATML1000:00 failed with error -61
> 
> It never gets an interrupt when the device reset is ready.
> 
> Jin, do you have any idea what is going on?
> 

Maybe neither the patch (http://dougvj.net/baytrail_gpio_quirk_v3.patch)
nor my patch breaks the touch screen.

I have tried the clean 3.15-rc2 with following patch which just adds
back the ACPIID "INT33FC", but the touch screen still doesn't work (To
avoid the i915 crash issue, I use with the boot option "nomodeset" in test).

diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 69e29f4..d79c6d7 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -180,6 +180,7 @@ static const struct acpi_device_id
acpi_lpss_device_ids[] = {
        { "80860F14", (unsigned long)&byt_sdio_dev_desc },
        { "80860F41", (unsigned long)&byt_i2c_dev_desc },
        { "INT33B2", },
+       { "INT33FC", },

        { "INT3430", (unsigned long)&lpt_dev_desc },
        { "INT3431", (unsigned long)&lpt_dev_desc },
diff --git a/drivers/pinctrl/pinctrl-baytrail.c
b/drivers/pinctrl/pinctrl-baytrail.c
index 6e8301f..447f1dc 100644
--- a/drivers/pinctrl/pinctrl-baytrail.c
+++ b/drivers/pinctrl/pinctrl-baytrail.c
@@ -572,6 +572,7 @@ static const struct dev_pm_ops byt_gpio_pm_ops = {

 static const struct acpi_device_id byt_gpio_acpi_match[] = {
        { "INT33B2", 0 },
+       { "INT33FC", 0 },
        { }
 };
 MODULE_DEVICE_TABLE(acpi, byt_gpio_acpi_match);

Since the clean 3.15-rc2 doesn't contain "INT33FC", so the baytrail gpio
doesn't actually go into effect.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/