linux-kernel - Re: [RESEND PATCH] regulator: core: Disable unused regulators after deferred probing is done

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140424133451.GZ12304@sirena.org.uk>
Date:	Thu, 24 Apr 2014 14:34:51 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Nishanth Menon <nm@...com>
Cc:	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Saravana Kannan <skannan@...eaurora.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Markus Pargmann <mpa@...gutronix.de>
Subject: Re: [RESEND PATCH] regulator: core: Disable unused regulators after
 deferred probing is done

On Wed, Apr 23, 2014 at 06:10:50PM -0500, Nishanth Menon wrote:
> From: Saravana Kannan <skannan@...eaurora.org>
> 
> regulator_init_complete does a scan of regulators which dont have
> always-on or consumers are automatically disabled as being unused.
> However, with deferred probing, late_initcall() is too soon to
> declare a regulator as unused as the regulator itself might not
> have registered due to defferal - Example: A regulator deffered due
> to i2bus not available which in turn is deffered due to pinctrl
> availability.
> 
> Since deferred probing is done in late_initcall(), do the cleanup of
> unused regulators by regulator_init_complete in late_initcall_sync
> instead of late_initcall.

I'll apply this however since as we discussed on IRC last night it's
going to make the issues with unconfigured regulators getting powered
off more severe before I do so I'll change things so that regulators
with no configuration at all don't get touched by the core.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)