linux-kernel - Re: [PATCH 04/11] perf hists: Add a couple of hists stat helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1398347203.1681.22.camel@leonhard>
Date:	Thu, 24 Apr 2014 22:46:43 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 04/11] perf hists: Add a couple of hists stat helper
 functions

2014-04-24 (목), 15:12 +0200, Jiri Olsa:
> On Thu, Apr 24, 2014 at 09:57:46PM +0900, Namhyung Kim wrote:
> > 2014-04-24 (목), 11:40 +0200, Jiri Olsa:
> > > maybe I'm missing some case, but why is not 'nr_non_filtered_samples'
> > > reset/increased in hists__reset_filter_stats/hists__inc_filter_stats functions?
> > 
> > Because basically number of sample is counted at input stage, and these
> > functions are called at output stage.  But if a new filter is applied,
> > we need to re-count the numbers for the filter so it needs to be counted
> > separately.
> 
> ok.. I'll queue this for perf/core

Thank you so much!
Namhyung


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/