linux-kernel - Re: [PATCHv3 3/9] extcon: max8997: Use devm_extcon_dev_allocate for extcon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Apr 2014 00:11:26 +0900
From:	Chanwoo Choi <cwchoi00@...il.com>
To:	Felipe Balbi <balbi@...com>
Cc:	Chanwoo Choi <cw00.choi@...sung.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>,
	gg@...mlogic.co.uk, Kishon Vijay Abraham I <kishon@...com>,
	ckeepax@...nsource.wolfsonmicro.com,
	Mark Brown <broonie@...nel.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCHv3 3/9] extcon: max8997: Use devm_extcon_dev_allocate for extcon_dev

On Thu, Apr 24, 2014 at 11:45 PM, Felipe Balbi <balbi@...com> wrote:
> On Thu, Apr 24, 2014 at 09:34:51PM +0900, Chanwoo Choi wrote:
>> This patch use devm_extcon_dev_allocate() to simplify the memory control
>> of extcon device.
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
>> ---
>>  drivers/extcon/extcon-max8997.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
>> index 804a446..e2ee2f5 100644
>> --- a/drivers/extcon/extcon-max8997.c
>> +++ b/drivers/extcon/extcon-max8997.c
>> @@ -699,8 +699,7 @@ static int max8997_muic_probe(struct platform_device *pdev)
>>       }
>>
>>       /* External connector */
>> -     info->edev = devm_kzalloc(&pdev->dev, sizeof(struct extcon_dev),
>> -                               GFP_KERNEL);
>> +     info->edev = devm_extcon_dev_allocate(&pdev->dev, max8997_extcon_cable);
>>       if (!info->edev) {
>
> and here you never check for IS_ERR(info->evdev)
>
> NAK
>
> I suspect all following patches have the same defect.

OK, I'll use IS_ERR() instead of checking NULL.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/