lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 24 Apr 2014 20:47:38 +0530 From: Balaji T K <balajitk@...com> To: Felipe Balbi <balbi@...com> CC: <chris@...ntf.net>, <ulf.hansson@...aro.org>, <linux-mmc@...r.kernel.org>, Linux OMAP Mailing List <linux-omap@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 3/5] mmc: host: omap_hsmmc: introduce new accessor functions On Thursday 27 March 2014 05:34 AM, Felipe Balbi wrote: > we introduce new accessors which provide for register > access with and without offsets. > > This is just to make sure newer versions of the IP > can access the new registers prepended at the beginning > of the address space. > > Signed-off-by: Felipe Balbi <balbi@...com> > --- > drivers/mmc/host/omap_hsmmc.c | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index d46f768..e596c6a 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -211,6 +211,42 @@ struct omap_hsmmc_host { > struct omap_mmc_platform_data *pdata; > }; > > +static inline int _omap_hsmmc_read(struct omap_hsmmc_host *host, > + u32 reg, bool offset) > +{ > + return readl(host->base + reg + (offset ? host->reg_offset : 0)); > +} > + > +static inline void _omap_hsmmc_write(struct omap_hsmmc_host *host, > + u32 reg, u32 val, bool offset) > +{ > + writel(val, host->base + reg + (offset ? host->reg_offset : 0)); > +} > + > +static inline int omap_hsmmc_read_offset(struct omap_hsmmc_host *host, I think you can rename this function as just omap_hsmmc_read (removing _offset suffix) > + u32 reg) > +{ > + return _omap_hsmmc_read(host, reg, true); > +} > + > +static inline void omap_hsmmc_write_offset(struct omap_hsmmc_host *host, and this one as omap_hsmmc_write since this version of read/write is most often used, the one with no_offset might be used less often. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists