linux-kernel - Re: [PATCH] Input: evdev - get rid of old workaround for EVIOCGBIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140424053738.GA1839@yabbi.redhat.com>
Date:	Thu, 24 Apr 2014 15:37:38 +1000
From:	Peter Hutterer <peter.hutterer@...-t.net>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org,
	David Herrmann <dh.herrmann@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: evdev - get rid of old workaround for EVIOCGBIT

On Wed, Apr 23, 2014 at 10:27:20PM -0700, Dmitry Torokhov wrote:
> We put this workaround in 2008 and the offending userspace has been fixed
> up long time ago; the link in the message is no longer valid either, so it
> is time to retire it.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

works for me, Reviewed-by: Peter Hutterer <peter.hutterer@...-t.net>

Cheers,
   Peter

> ---
>  drivers/input/evdev.c | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
> index ce953d8..fd325ec 100644
> --- a/drivers/input/evdev.c
> +++ b/drivers/input/evdev.c
> @@ -629,12 +629,10 @@ static int str_to_user(const char *str, unsigned int maxlen, void __user *p)
>  	return copy_to_user(p, str, len) ? -EFAULT : len;
>  }
>  
> -#define OLD_KEY_MAX	0x1ff
>  static int handle_eviocgbit(struct input_dev *dev,
>  			    unsigned int type, unsigned int size,
>  			    void __user *p, int compat_mode)
>  {
> -	static unsigned long keymax_warn_time;
>  	unsigned long *bits;
>  	int len;
>  
> @@ -652,24 +650,8 @@ static int handle_eviocgbit(struct input_dev *dev,
>  	default: return -EINVAL;
>  	}
>  
> -	/*
> -	 * Work around bugs in userspace programs that like to do
> -	 * EVIOCGBIT(EV_KEY, KEY_MAX) and not realize that 'len'
> -	 * should be in bytes, not in bits.
> -	 */
> -	if (type == EV_KEY && size == OLD_KEY_MAX) {
> -		len = OLD_KEY_MAX;
> -		if (printk_timed_ratelimit(&keymax_warn_time, 10 * 1000))
> -			pr_warning("(EVIOCGBIT): Suspicious buffer size %u, "
> -				   "limiting output to %zu bytes. See "
> -				   "http://userweb.kernel.org/~dtor/eviocgbit-bug.html\n",
> -				   OLD_KEY_MAX,
> -				   BITS_TO_LONGS(OLD_KEY_MAX) * sizeof(long));
> -	}
> -
>  	return bits_to_user(bits, len, size, p, compat_mode);
>  }
> -#undef OLD_KEY_MAX
>  
>  static int evdev_handle_get_keycode(struct input_dev *dev, void __user *p)
>  {
> -- 
> 1.9.0
> 
> 
> -- 
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/