linux-kernel - RE: [PATCH] staging: comedi: addi_apci_1564: separate from addi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <DC148C5AA1CEBA4E87973D432B1C2D8825E1621C@P3PWEX4MB008.ex4.secureserver.net>
Date:	Thu, 24 Apr 2014 18:43:32 +0000
From:	Hartley Sweeten <HartleyS@...ionengravers.com>
To:	Chase Southwood <chase.southwood@...oo.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	"abbotti@....co.uk" <abbotti@....co.uk>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] staging: comedi: addi_apci_1564: separate from
 addi_common.c

On Thursday, April 24, 2014 12:19 AM, Chase Southwood wrote:
> Using the addi-data "common" code in addi_apci_1564 introduces a lot of
> bloat.  By separating this driver off from addi_common.c, a lot of the
> common code can be stripped out.  This patch copies the code over from
> addi_common.c, and removes the #include of the file.  The auto_attach
> function from the common code replaces the one that was previously in this
> driver, though renamed to that it stays within the namespace associated
> with this driver, and the detach function has been renamed for this reason
> as well.
>
> Signed-off-by: Chase Southwood <chase.southwood@...oo.com>
> Cc: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Ian Abbott <abbotti@....co.uk>
> ---
> Compile tested only.

Looks good.

Reviewed-by: H Hartley Sweeten <hsweeten@...ionengravers.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/