linux-kernel - Re: [PATCH] veth: Allow a peer to be up at creation time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140424.164221.1323078752352256197.davem@davemloft.net>
Date:	Thu, 24 Apr 2014 16:42:21 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	slash@...auone-net.jp
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] veth: Allow a peer to be up at creation time

From: Kusanagi Kouichi <slash@...auone-net.jp>
Date: Thu, 24 Apr 2014 17:56:06 +0900

> Currently, a veth peer cannot be up at creation time.
> 
> # ip link add type veth peer up
> RTNETLINK answers: Transport endpoint is not connected
> 
> Signed-off-by: Kusanagi Kouichi <slash@...auone-net.jp>

I do not think this is sufficient.

There are many problems if you signal an error after we do:

	err = register_netdevice(dev);

For one thing, you aren't unregistering 'dev' in that error path,
furthermore, priv->peer points to the netdevice you are unregistering.

I think this cannot be done, what you aim to achieve, and we just
simply have to live with the current semantics.  Bring the device
up after you have created it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/