linux-kernel - Re: [PATCH v2] pci: Allow hotplug service drivers to operate in polling mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140424212610.GH29593@google.com>
Date:	Thu, 24 Apr 2014 15:26:10 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Rajat Jain <rajatxjain@...il.com>
Cc:	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	Rajat Jain <rajatjain@...iper.net>,
	Guenter Roeck <groeck@...iper.net>
Subject: Re: [PATCH v2] pci: Allow hotplug service drivers to operate in
 polling mode

On Mon, Mar 31, 2014 at 04:51:23PM -0700, Rajat Jain wrote:
> Today the PCIe port bus driver disables the Hot-plug service if the
> port device does not have the capability to generate interrupts.
> However, a user must be able to use the "pciehp_poll_mode" parameter
> to use the pciehp in polling method in such a case. Today it is not
> possible.
> 
> This patch allows a hotplug service driver to decide whether or not
> it would like to continue in absense of interrupts.
> 
> Signed-off-by: Rajat Jain <rajatxjain@...il.com>
> Signed-off-by: Rajat Jain <rajatjain@...iper.net>
> Signed-off-by: Guenter Roeck <groeck@...iper.net>

Applied to pci/hotplug for v3.16, thanks!

> ---
> v2: Drop the extra debug msg in pciehp
>     (and just retain the changes in portdrv_core.c)
> 
>  drivers/pci/pcie/portdrv_core.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pcie/portdrv_core.c b/drivers/pci/pcie/portdrv_core.c
> index 0b6e766..ba31deb 100644
> --- a/drivers/pci/pcie/portdrv_core.c
> +++ b/drivers/pci/pcie/portdrv_core.c
> @@ -377,10 +377,13 @@ int pcie_port_device_register(struct pci_dev *dev)
>  	/*
>  	 * Initialize service irqs. Don't use service devices that
>  	 * require interrupts if there is no way to generate them.
> +	 * However, some drivers may have a polling mode (e.g pciehp_poll_mode)
> +	 * that can be used in absense of irqs. Allow them to determine
> +	 * if that is to be used.
>  	 */
>  	status = init_service_irqs(dev, irqs, capabilities);
>  	if (status) {
> -		capabilities &= PCIE_PORT_SERVICE_VC;
> +		capabilities &= PCIE_PORT_SERVICE_VC | PCIE_PORT_SERVICE_HP;
>  		if (!capabilities)
>  			goto error_disable;
>  	}
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/