linux-kernel - Re: [PATCH 1/2] tty serial: xr17c15x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20140425062213.GA2371@deathray>
Date:	Fri, 25 Apr 2014 01:22:13 -0500
From:	Michael Welling <mwelling@...e.org>
To:	gnomes@...rguk.ukuu.org.uk
Cc:	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
	jslaby@...e.cz
Subject: Re: [PATCH 1/2] tty serial: xr17c15x driver

I believe I found a related unresolved kernel bug:
"Bug 61961 – My Exar Corp. XR17C/D152 Dual PCI UART modem does not
work with 3.8.0"

The issue appears to be the same and gave me a clue as to where to
look.

Comparing the code from 3.5 to 3.8, I noticed that the UART_CAP_SLEEP
flag was added to the XR17D15X Exar chip.

Then I noticed what appears to be a bug in the serial8250_set_sleep
function:
.
.
        if ((p->port.type == PORT_XR17V35X) ||
           (p->port.type == PORT_XR17D15X)) {
                serial_out(p, UART_EXAR_SLEEP, 0xff);
                return;
        }
.
.

The if statement disregards the sleep parameter and always puts all of
the ports to sleep.

Something like this would be more appropriate:
.
.
        if ((p->port.type == PORT_XR17V35X) ||
           (p->port.type == PORT_XR17D15X)) {
                serial_out(p, UART_EXAR_SLEEP, sleep ? 0xff : 0);
                return;
        }
.
.

Now I don't know that this is the problem yet and I would like someone
to confirm that I am not crazy.

I can try the patch at work tomorrow and see if it fixes the issue.
Then maybe we can close Bug 61961.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/