lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Apr 2014 14:09:47 +0530 From: "Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com> To: Viresh Kumar <viresh.kumar@...aro.org> CC: "Rafael J. Wysocki" <rjw@...ysocki.net>, Meelis Roos <mroos@...ux.ee>, "cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/3] cpufreq, longhaul: Fix double invocation of cpufreq_freq_transition_begin/end On 04/25/2014 02:07 PM, Viresh Kumar wrote: > On 25 April 2014 13:48, Srivatsa S. Bhat > <srivatsa.bhat@...ux.vnet.ibm.com> wrote: > >> diff --git a/drivers/cpufreq/longhaul.c b/drivers/cpufreq/longhaul.c > >> @@ -269,8 +269,6 @@ static void longhaul_setstate(struct cpufreq_policy *policy, > > This routine has this code as well: > > mult = mults[mults_index & 0x1f]; > if (mult == -1) > return; > speed = calc_speed(mult); > if ((speed > highest_speed) || (speed < lowest_speed)) > return; > > And so it might return without changing frequency and that's why I > left this driver earlier for this change.. So, please return -EINVAL > from here.. > Ok, I'll address this in the next version. Thanks for pointing this out! Regards, Srivatsa S. Bhat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists