linux-kernel - Re: [PATCHv4 5/9] extcon: max14577: Use devm_extcon_dev_allocate for extcon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140425151606.GI29632@saruman.home>
Date:	Fri, 25 Apr 2014 10:16:06 -0500
From:	Felipe Balbi <balbi@...com>
To:	Chanwoo Choi <cw00.choi@...sung.com>
CC:	<linux-kernel@...r.kernel.org>, <myungjoo.ham@...sung.com>,
	<balbi@...com>, <gg@...mlogic.co.uk>, <kishon@...com>,
	<ckeepax@...nsource.wolfsonmicro.com>, <broonie@...nel.org>,
	<k.kozlowski@...sung.com>, <kyungmin.park@...sung.com>
Subject: Re: [PATCHv4 5/9] extcon: max14577: Use devm_extcon_dev_allocate for
 extcon_dev

On Fri, Apr 25, 2014 at 09:42:20AM +0900, Chanwoo Choi wrote:
> This patch use devm_extcon_dev_allocate() to simplify the memory control
> of extcon device.
> 
> Cc: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Reviewed-by: Felipe Balbi <balbi@...com>

> ---
>  drivers/extcon/extcon-max14577.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
> index d17dd4f..d49e891 100644
> --- a/drivers/extcon/extcon-max14577.c
> +++ b/drivers/extcon/extcon-max14577.c
> @@ -739,14 +739,15 @@ static int max14577_muic_probe(struct platform_device *pdev)
>  	}
>  
>  	/* Initialize extcon device */
> -	info->edev = devm_kzalloc(&pdev->dev, sizeof(*info->edev), GFP_KERNEL);
> -	if (!info->edev) {
> +	info->edev = devm_extcon_dev_allocate(&pdev->dev,
> +					      max14577_extcon_cable);
> +	if (IS_ERR(info->edev)) {
>  		dev_err(&pdev->dev, "failed to allocate memory for extcon\n");
>  		return -ENOMEM;
>  	}
>  
>  	info->edev->name = dev_name(&pdev->dev);
> -	info->edev->supported_cable = max14577_extcon_cable;
> +
>  	ret = devm_extcon_dev_register(&pdev->dev, info->edev);
>  	if (ret) {
>  		dev_err(&pdev->dev, "failed to register extcon device\n");
> -- 
> 1.8.0
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)