linux-kernel - Re: [PATCH 1/5] iio: exynos_adc: use indio_dev->dev structure to handle child nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=V28_iDiNWeX6bXLzMW5kWygJz-YAExJkETJKgTDicHQg@mail.gmail.com>
Date:	Fri, 25 Apr 2014 08:46:31 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	Naveen Krishna Chatradhi <ch.naveen@...sung.com>,
	Jonathan Cameron <jic23@...nel.org>
Cc:	linux-iio <linux-iio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Naveen Krishna <naveenkrishna.ch@...il.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	"cpgs ." <cpgs@...sung.com>, Grant Grundler <grundler@...omium.org>
Subject: Re: [PATCH 1/5] iio: exynos_adc: use indio_dev->dev structure to
 handle child nodes

Naveen,

Thanks for sending this.  Given that Jonathan Cameron was involved in
the previous discussion, it probably would have been wise to include
him on the CC list.

On Fri, Apr 25, 2014 at 3:14 AM, Naveen Krishna Chatradhi
<ch.naveen@...sung.com> wrote:
> From: Naveen Krishna Ch <ch.naveen@...sung.com>
>
> Using pdev->dev with device_for_each_child() would iterate over all
> of the children of the platform device and delete them.
> Thus, causing crashes during module unload.
>
> We should be using the indio_dev->dev structure for
> registering/unregistering child nodes.
>
> Signed-off-by: Naveen Krishna Ch <ch.naveen@...sung.com>
> ---
> This change was tested on top of
>    https://lkml.org/lkml/2014/4/21/481 from Doug.
>
>  drivers/iio/adc/exynos_adc.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reported-by: Doug Anderson <dianders@...omium.org>
Reviewed-by: Doug Anderson <dianders@...omium.org>
Tested-by: Doug Anderson <dianders@...omium.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/