linux-kernel - Re: [PATCH 3/5] iio: exynos_adc: reduce timeout and use wait_for_completion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Uds1i0dsuhFKXbNY6+kVRsFe0D0EQ3FATJnwjPGD3k0Q@mail.gmail.com>
Date:	Fri, 25 Apr 2014 09:28:13 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	Naveen Krishna Chatradhi <ch.naveen@...sung.com>,
	Jonathan Cameron <jic23@...nel.org>
Cc:	linux-iio <linux-iio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Naveen Krishna <naveenkrishna.ch@...il.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	"cpgs ." <cpgs@...sung.com>, Grant Grundler <grundler@...omium.org>
Subject: Re: [PATCH 3/5] iio: exynos_adc: reduce timeout and use wait_for_completion_timeout

Naveen,

On Fri, Apr 25, 2014 at 3:14 AM, Naveen Krishna Chatradhi
<ch.naveen@...sung.com> wrote:
> ADC module on Exynos5 SoCs runs at 600KSPS. At this conversion rate,
> waiting for 1000 msecs is wasteful (incase of h/w failure).
>
> Hence, reduce the time out to 100msecs and use
> wait_for_completion_timeout() instead of
> wait_for_completion_interruptible_timeout()
>
> Also, handle the return values in exynos_raw_read() call.

You probably didn't need to mention this--it's just a natural part of
changing from wait_for_completion_interruptible_timeout() to
wait_for_completion_timeout().

>
> Change-Id: Icb8cade162094b2777c9f3c77120635deef5947c

Please don't send upstream with Change-Id.  Have you considered patman
<http://git.denx.de/?p=u-boot.git;a=blob;f=tools/patman/README;hb=refs/heads/master>?

> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@...sung.com>
> ---
> This change is a part of the patch reviewd at https://lkml.org/lkml/2013/11/5/92
>
>  drivers/iio/adc/exynos_adc.c |   18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)

Other than problems above, this looks fine to me.  If you fix them,
feel free to add my Reviewed-by tag.

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/