linux-kernel - Re: [PATCHv3 05/14] HSI: Add channel resource support to HSI clients

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Apr 2014 19:32:47 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Pavel Machek <pavel@....cz>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Shubhrajyoti Datta <omaplinuxkernel@...il.com>,
	Carlos Chinea <cch.devel@...il.com>,
	Tony Lindgren <tony@...mide.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Kumar Gala <galak@...eaurora.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	Pali Rohár <pali.rohar@...il.com>,
	Ивайло Димитров 
	<freemangordon@....bg>,
	Joni Lapilainen <joni.lapilainen@...il.com>,
	Aaro Koskinen <aaro.koskinen@....fi>
Subject: Re: [PATCHv3 05/14] HSI: Add channel resource support to HSI clients

On Sat, Apr 19, 2014 at 09:11:26PM +0200, Pavel Machek wrote:
> Hi!
> 
> > Make HSI channel ids platform data, which can be provided
> > by platform data.
> >
> 
> >  static void hsi_client_release(struct device *dev)
> >  {
> > -	kfree(to_hsi_client(dev));
> > +	struct hsi_client *cl = to_hsi_client(dev);
> > +
> > +	if (cl->tx_cfg.channels)
> > +		kfree(cl->tx_cfg.channels);
> > +	if (cl->rx_cfg.channels && cl->rx_cfg.channels != cl->tx_cfg.channels)
> > +		kfree(cl->rx_cfg.channels);
> > +
> > +	kfree(cl);
> 
> Can cl->rx_cfg.channels == cl->tx_cfg.channels happen? That seems
> like quite a hack :-(.

Yes it could happen. I have updated this for PATCHv4 (so that it can
no longer happen).

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)