linux-kernel - Re: [PATCH v7 1/2] serial: sc16is7xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Apr 2014 14:24:23 -0400
From:	Jon Ringle <jon@...gle.org>
To:	Alexander Shiyan <shc_work@...l.ru>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jon Ringle <jringle@...dpoint.com>
Subject: Re: [PATCH v7 1/2] serial: sc16is7xx

On Fri, Apr 25, 2014 at 1:40 PM, Alexander Shiyan <shc_work@...l.ru> wrote:
> Fri, 25 Apr 2014 10:26:40 -0700 от Greg KH <gregkh@...uxfoundation.org>:
>> On Thu, Apr 24, 2014 at 08:56:06PM -0400, jon@...gle.org wrote:
>> > From: Jon Ringle <jringle@...dpoint.com>
>> >
>> > The SC16IS7xx is a slave I2C-bus/SPI interface to a single-channel
>> > high performance UART. The SC16IS7xx's internal register set is
>> > backward-compatible with the widely used and widely popular 16C450.
>> >
>> > The SC16IS7xx also provides additional advanced features such as
>> > auto hardware and software flow control, automatic RS-485 support, and
>> > software reset.
>> >
>> > Signed-off-by: Jon Ringle <jringle@...dpoint.com>
>> > ---
>> >  drivers/tty/serial/Kconfig       |    9 +
>> >  drivers/tty/serial/Makefile      |    1 +
>> >  drivers/tty/serial/sc16is7xx.c   | 1279 ++++++++++++++++++++++++++++++++++++++
>> >  include/uapi/linux/serial_core.h |    3 +
>> >  4 files changed, 1292 insertions(+)
>> >  create mode 100644 drivers/tty/serial/sc16is7xx.c
>>
>> I get a few build warnings with this patch applied:
>>
>> drivers/tty/serial/sc16is7xx.c:1059:12: warning: ‘sc16is7xx_probe’ defined but not used [-Wunused-function]
>>  static int sc16is7xx_probe(struct device *dev,
>>             ^
>> drivers/tty/serial/sc16is7xx.c:1175:12: warning: ‘sc16is7xx_remove’ defined but not used [-Wunused-function]
>>  static int sc16is7xx_remove(struct device *dev)
>>             ^
>> drivers/tty/serial/sc16is7xx.c:1214:29: warning: ‘regcfg’ defined but not used [-Wunused-variable]
>>  static struct regmap_config regcfg = {
>>                              ^
>>
>> Can you send a follow-on patch to fix them?
>
> Seems this just should contain: "depends on I2C" in the Kconfig.

I can add "depends on I2C" in Kconfig for now, but I'm just wondering
how would this be dealt with when sometime in the future this driver
supports either I2C or SPI? Can the "depends on" be conditional
somehow?

Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/